Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the bucket from the app name when checking directories. #2435

Merged
merged 2 commits into from
Jul 29, 2018

Conversation

Ardelean-Calin
Copy link
Contributor

In the app manifest, specifying dependencies with the bucket on which to find that dependency is supported (see the flutter manifest for an example). The problem, however, is that when running scoop status after installing an app such as flutter, we get an error message that some dependencies are supposedly missing:

image

This message is however wrong, since oraclejdk8 was successfully installed. The problem is that flutter checks if a dependency is installed by checking whether a directory with the name of that dependency exists in the apps folder. In this case it checks for the folder java/oraclejdk8, doesn't find it, since it actually exists as oraclejdk8 and marks the dependency as being not satisfied.

This small pull request fixes that:

image

@r15ch13
Copy link
Member

r15ch13 commented Jul 29, 2018

installed() is doing the right thing, but app_status() is passing in the wrong data:
https://github.com/lukesampson/scoop/blob/88040972a30b459a3859c7c2f883e47e19da9f84/lib/core.ps1#L117

Changing it to the following would be better.

    $deps = @(runtime_deps $manifest) | Where-Object {
        $app, $bucket, $null = parse_app $_
        return !(installed $app)
    }

Your change can still be used as a fallback.

@r15ch13 r15ch13 merged commit f8c0ca7 into ScoopInstaller:master Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants