scoop bin path should not be added at the begninng of the existing PATH string

[copdips]

Hello,

The ensure_in_path function in core.ps1 adds the scoop bin path at the beginning of the PATH, which might cause some unexpected problem if some other existing path has the same exe.

Usually, we should append the new path (scoop one here) to the existing PATH.

https://github.com/lukesampson/scoop/blob/master/lib/core.ps1#L426
https://github.com/lukesampson/scoop/blob/master/lib/core.ps1#L427

maybe following code is better:

env 'PATH' $global "$path;$dir" # for future sessions...
$env:PATH = "$env:PATH;$dir" # for this session

same thing for the function add_first_in_path
https://github.com/lukesampson/scoop/blob/master/lib/install.ps1#L1035

[sebma]

@copdips Hi, I just came across your issue and couldn't help but notice your were working on the ensure_in_path function which is called by the ensure_scoop_in_path function.

I cannot install scoop on my system because the ensure_scoop_in_path function needs a non-null ($global) argument however the scoop installer calls it without any argument (https://github.com/lukesampson/scoop/blob/master/bin/install.ps1#L72).

I have seen any commit on this project since a month.

Can you give a little bit of your time to help me with issue #4177 ?

[sebma]

@copdips Found it 😄
I had an env alias which was causing a conflict with the scoop env function (a function which I didn't know was defined).