Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will scoop-core related PR chang merging target to 'develop' branch? #3376

Closed
niheaven opened this issue Apr 25, 2019 · 1 comment
Closed

Comments

@niheaven
Copy link
Member

Or still target to 'master'?

@Ash258
Copy link
Contributor

Ash258 commented Apr 25, 2019

I hope so. After bucket extraction is done we could adopt proper support for #2939. Then all prs will be merged into develop, when it will be tested for few days and then it could be merged into master.

I propose this flow:

  1. Create PR against develop

    1. Review
    2. Merge
  2. Wait for early adopters to report some bugs.

  3. If there are none / all are fixed

    1. Create PR from develop to master
  4. Merge it to master for everyone

  5. Repeat with next PR

This will make sure that the PR is safe for a wider user base, rather then pushing PRs into master directly, so normal users will not experience so many bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants