Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): Use Join-Path instead of string gluing. #3566

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

Ash258
Copy link
Contributor

@Ash258 Ash258 commented Jul 20, 2019

While working on Actions I encounter problem with aria2 downloading. I can pretty simply override function Get-AppFilePath without problem so I can feed it with whatever I want to get correct path, but Aria2 is having problems with mixing \ and /

Before

Ash258/Scoop-GithubActions#38 (comment)

A

After

Ash258/Scoop-GithubActions#38 (comment)

B

@r15ch13 r15ch13 merged commit 9c04608 into ScoopInstaller:develop Oct 4, 2019
@Ash258 Ash258 deleted the patch-3 branch December 23, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants