Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update): support $persist_dir in uninstaller.script #3692

Merged
merged 1 commit into from
Oct 23, 2019
Merged

fix(update): support $persist_dir in uninstaller.script #3692

merged 1 commit into from
Oct 23, 2019

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Oct 17, 2019

$persist_dir in uninstaller.script only works when uninstall but not when update.

@Ash258
Copy link
Contributor

Ash258 commented Oct 17, 2019

I do not see a reason to add internal variable, which is not used anywhere.

You have access to almost all core functions from manifests code blocks. And adding $persist_dir = persistdir $app $global is not something really critical you need to hack over tons of lines or escape lots of quotes. It is simple one liner.

@linsui
Copy link
Contributor Author

linsui commented Oct 17, 2019

It is useful when some files need to be persist manully. $persist_dir is available in uninstaller.script when uninstall but not when update, which is confusing. I didn't notice this problem because I test a manifest by uninstall and install.

@Ash258
Copy link
Contributor

Ash258 commented Oct 18, 2019

I see what you mean. Yeath this could go in for small period of time.

I am currently working on #2952, which will cover this use case. (#3708)

@Ash258
Copy link
Contributor

Ash258 commented Oct 23, 2019

@r15ch13, @rasa Could you please fast patch this to develop and sync to master?

@r15ch13 r15ch13 merged commit 6eb90c9 into ScoopInstaller:develop Oct 23, 2019
@linsui linsui deleted the unins branch October 24, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants