build(checkver): Fix output with '-Version'

[niheaven]

Before

After

[Ash258]

If I can see correctly, main changes are:

• https://github.com/lukesampson/scoop/pull/3774/files#diff-6d5ec5a5587d8c2e2cd120423846e581L308-L310
• https://github.com/lukesampson/scoop/pull/3774/files#diff-6d5ec5a5587d8c2e2cd120423846e581R78-R82
• https://github.com/lukesampson/scoop/pull/3774/files#diff-6d5ec5a5587d8c2e2cd120423846e581R202-R206

Rest is just messy compare due to nested if (!$ver) {, which was not changed right?

[r15ch13]

The same logic could be archived without the indentation by adding the check for $Version later.

Change

https://github.com/lukesampson/scoop/blob/a9fa775d59b14e7dce335313faa0eff855469764/bin/checkver.ps1#L274-L280

To

    if (!$ver) {
        next "couldn't find new version in $url"
        continue
    }

    if($Version) {
        $expected_ver = $ver
        $ver = $Version
    }

    # Skip actual only if versions are same and there is no -f
    if (($ver -eq $expected_ver) -and !$ForceUpdate -and $SkipUpdated) { continue }

[niheaven]

@Ash258 Yes, rest is just caused by indenting

@r15ch13 The big if just skips time-consuming version finding step.

[niheaven]

Tested after resolve conflicts (merged current 'develop' branch)

[rashil2000]

Will it be possible to isolate indentation changes in a separate commit (in this PR itself)? Otherwise it's difficult to review.

[niheaven]

Separate into two commits, Part I is just indenting, while Part II is fixed code.

[Ash258]

[niheaven]

Wonderful feature that I never found in GitHub.

[rashil2000]

Right, completely forgot about this 😅

But this does look a lot cleaner: