Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autoupdate unless URL is accessible #3811

Closed
Ash258 opened this issue Dec 30, 2019 · 0 comments
Closed

Do not autoupdate unless URL is accessible #3811

Ash258 opened this issue Dec 30, 2019 · 0 comments

Comments

@Ash258
Copy link
Contributor

Ash258 commented Dec 30, 2019

Implemented in Shovel

As soon as manifest specify hash extraction, and hash is found, URL is not checked. This lead to possible problem when hash was extracted correctly, but installation failed since developers changed URL.

Change should be simple:

https://github.com/lukesampson/scoop/blob/a9fa775d59b14e7dce335313faa0eff855469764/lib/autoupdate.ps1#L262

This line need to test HTTP Status and then return hash. Cannot think right now how to test remote file existence and do not download full file. It should be possible to download few bytes and see status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant