Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoop is considered installed when zip failed to download #3829

Open
jetersen opened this issue Jan 22, 2020 · 2 comments
Open

Scoop is considered installed when zip failed to download #3829

jetersen opened this issue Jan 22, 2020 · 2 comments

Comments

@jetersen
Copy link

jetersen commented Jan 22, 2020 •
edited
Loading

The install condition for scoop is not good enough as an empty folder is considered as if scoop was installed successfully.

image
@Ash258
Copy link
Contributor

Ash258 commented Jan 22, 2020

Duplicate of #3816

scoop list/status will tell you it was failed. Keeping the folder is for debug purpose as there are logs.

as an empty folder is considered as if scoop was installed successfully.

Not true. Successfull installation is considered only if install.json exists in current folder

image

@jetersen
Copy link
Author

jetersen commented Jan 22, 2020 •
edited
Loading

This is not true when scoop fails to install

When scoop fails to unzip into current, scoop is considered installed and there is no install.json
This happens when you try and run the install.ps1 on get.scoop.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jetersen @Ash258