-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scoop-update): Fix scoop update -a requiring arguments #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niheaven
approved these changes
Nov 23, 2021
niheaven
changed the title
Fix scoop update -a requiring arguments
fix(scoop-update): Fix scoop update -a requiring arguments
Nov 23, 2021
Closed
ac71fcc fixes issue that |
@niheaven should we merge this one on stable as well? |
Is it a critical fix? If so, we could open a merging PR. |
niheaven
added a commit
that referenced
this pull request
Dec 25, 2021
Related PRs: - #4531 @filmor - ac71fcc @niheaven - #4535 @rashil2000 - #4522 @pratikpc - #4550 @niheaven - #4528 @niheaven - #4532 @MrNuggelz - #4155 @MrNuggelz Co-authored-by: @rashil2000 - #4581 @niheaven - fb496c4 @rashil2000 - #4543 @rashil2000 Co-authored-by: @niheaven - #4555 @rashil2000 - 3c90d1a @rashil2000 - 2ec00d5 @rashil2000 - #4567 @rashil2000 - cbe29ed @rashil2000 - #4570 @niheaven - #4582 @niheaven - #4571 @niheaven - #3244 @nickbudi - #3821 @jfastnacht Co-authored-by: @rasa - #4578 @tukanos - #4579 @rashil2000 Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com> Co-authored-by: Ross Smith II <ross@smithii.com> Co-authored-by: Benedikt Reinartz <filmor@gmail.com> Co-authored-by: Joris <MrNuggelz@users.noreply.github.com> Co-authored-by: Pratik Chowdhury <pratikc@live.co.uk> Co-authored-by: Rashil Gandhi <rashil2000@gmail.com> Co-authored-by: nickbudi <nickbudi@users.noreply.github.com> Co-authored-by: Julian <github@fastnacht.consulting> Co-authored-by: tukanos <patrik.svestka@gmail.com>
se35710
pushed a commit
to se35710/scoop
that referenced
this pull request
Mar 8, 2022
se35710
pushed a commit
to se35710/scoop
that referenced
this pull request
Mar 8, 2022
Related PRs: - ScoopInstaller#4531 @filmor - ac71fcc @niheaven - ScoopInstaller#4535 @rashil2000 - ScoopInstaller#4522 @pratikpc - ScoopInstaller#4550 @niheaven - ScoopInstaller#4528 @niheaven - ScoopInstaller#4532 @MrNuggelz - ScoopInstaller#4155 @MrNuggelz Co-authored-by: @rashil2000 - ScoopInstaller#4581 @niheaven - fb496c4 @rashil2000 - ScoopInstaller#4543 @rashil2000 Co-authored-by: @niheaven - ScoopInstaller#4555 @rashil2000 - 3c90d1a @rashil2000 - 2ec00d5 @rashil2000 - ScoopInstaller#4567 @rashil2000 - cbe29ed @rashil2000 - ScoopInstaller#4570 @niheaven - ScoopInstaller#4582 @niheaven - ScoopInstaller#4571 @niheaven - ScoopInstaller#3244 @nickbudi - ScoopInstaller#3821 @jfastnacht Co-authored-by: @rasa - ScoopInstaller#4578 @tukanos - ScoopInstaller#4579 @rashil2000 Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com> Co-authored-by: Ross Smith II <ross@smithii.com> Co-authored-by: Benedikt Reinartz <filmor@gmail.com> Co-authored-by: Joris <MrNuggelz@users.noreply.github.com> Co-authored-by: Pratik Chowdhury <pratikc@live.co.uk> Co-authored-by: Rashil Gandhi <rashil2000@gmail.com> Co-authored-by: nickbudi <nickbudi@users.noreply.github.com> Co-authored-by: Julian <github@fastnacht.consulting> Co-authored-by: tukanos <patrik.svestka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4530
I misunderstood how
:
acts ingetopt
. I have removed it entirely, I assume that the-q
parameter was also not supposed to get an argument. The error on-q
was introduced with #2260.