-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(decompress): Fix nested Zstd archive extraction #4608
Conversation
Also fix test cases error
Do you have a manifest to test before and after this change? |
Run the test, since before and after the PR, msys type manifest always works well... The error only occured when destination dir is not archive dir. PS, test will hault before since waiting for interaction of overwriting, and a wrong function name... |
I made a test manifest: test.json{
"version": "11.2.0-2",
"description": "GNU Compiler Collection (Mingw-w64 port from MSYS2 project)",
"homepage": "http://mingw-w64.org/doku.php",
"license": "GPL-3.0-or-later,ZPL-2.1,...",
"architecture": {
"64bit": {
"url": [
"https://mirror.msys2.org/mingw/mingw64/mingw-w64-x86_64-binutils-2.37-4-any.pkg.tar.zst"
],
"hash": [
"a518d2630c11fe363abd394763d0bb82fdde72386ffb58d87ecc8f46cbe878d6"
]
},
"32bit": {
"url": [
"https://mirror.msys2.org/mingw/mingw32/mingw-w64-i686-binutils-2.37-4-any.pkg.tar.zst"
],
"hash": [
"20b2e5beefb831c665ac5b1be4feb447e0f4e543e15c0fd5855dc0c258a29a02"
]
}
},
"extract_to": "test"
} Before: After: |
@rashil2000 Do you have some time to test this PR (I've attached a testing manifest)? I've some |
Looks like the tests of https://ci.appveyor.com/project/chawyehsu/scoop/builds/42173333/job/g5alk2c1s63s50aj#L245 @niheaven Could you please take a look at this. I don't know why the Core's appveyor CI stopped. |
It's caused by wrong https://ci.appveyor.com/project/niheaven/scoop/builds/42177522/job/l8b7kyla9deyiohx |
Also fix test cases error
Description
There're some stupid mistakes in
Expand-ZstdArchive()
which are totally introduced by me (#4372). This one fixes them, and bypasses decompress test.How Has This Been Tested?
Checklist: