Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installed): Fix 'core/installed' that mark failed app as 'installed' #4650

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jan 12, 2022

Description

  • Check if NO_JUNCTIONS is set
    • set: use current version
    • unset: use current
  • Check if there is install.json file in versioned directory

Motivation and Context

Closes #4648

How Has This Been Tested?

Before:

image

After:

image

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
    - [ ] I have updated the tests accordingly.

@niheaven
Copy link
Member Author

Since this is a hotfix for 'develop' branch, could you guys take some time to review it? @chawyehsu @issaclin32 @rashil2000

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants