-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci,tests): Support both AppVeyor and GitHub Actions #4655
refactor(ci,tests): Support both AppVeyor and GitHub Actions #4655
Conversation
Signed-off-by: Chawye Hsu <chawyehsu@hotmail.com>
Signed-off-by: Chawye Hsu <chawyehsu@hotmail.com>
`test\bin\init.ps1`: Refactor to support both AppVeyor and GitHub Actions. The Zstd helper will only be downloaded and installed on the AppVeyor CI. On GitHub Actions it's built-in on the CI. `test\bin\test.ps1`: Refactor to support both AppVeyor and GitHub Actions. Only on AppVeyor CI the TestResults will be uploaded. Exclusion rules of tests are only applied when tests are called from the Core itself on CI, skipped when tests are called either from the external bucket or not on CI. `test\Scoop-Manifest.Test.ps1`: Manifests test and validation have been merged into `test\Import-Bucket-Tests.ps1`, since the main bucket has been separated from the Core and there is no need to do manifest test in the Core repo. Signed-off-by: Chawye Hsu <chawyehsu@hotmail.com>
Signed-off-by: Chawye Hsu <chawyehsu@hotmail.com>
Could you please update CHANGELOG with an item under |
Added |
We would be running it on each push and pull request, so I still feel ci.yml reflects the name better |
I've no idea, and it seems that @chawyehsu use |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, perfect job!
Description
refactor(ci,tests): Support both AppVeyor and GitHub Actions
Motivation and Context
test\bin\init.ps1
: Refactor to support both AppVeyor and GitHubActions. The Zstd helper will only be downloaded and installed on
the AppVeyor CI. On GitHub Actions it's built-in on the CI.
test\bin\test.ps1
: Refactor to support both AppVeyor and GitHubActions. Only on AppVeyor CI the TestResults will be uploaded.
Exclusion rules of tests are only applied when tests are called
from the Core itself on CI, skipped when tests are called either
from the external bucket or not on CI.
test\Scoop-Manifest.Test.ps1
: Manifests test and validation havebeen merged into
test\Import-Bucket-Tests.ps1
, since the mainbucket has been separated from the Core and there is no need to do
manifest test in the Core repo.
How Has This Been Tested?
For Core:
GitHub Actions - WindowsPowerShell: https://github.com/ScoopInstaller/Scoop/runs/4805272264?check_suite_focus=true
GitHub Actions - PowerShell: https://github.com/ScoopInstaller/Scoop/runs/4805272339?check_suite_focus=true
AppVeyor - WindowsPowerShell: https://ci.appveyor.com/project/chawyehsu/scoop/builds/42190020/job/tu163a54spx9xny9
AppVeyor - PowerShell: https://ci.appveyor.com/project/chawyehsu/scoop/builds/42190020/job/026e90ce719k4ewg
For bucket:
GitHub Actions - WindowsPowerShell: https://github.com/chawyehsu/bucket-gh-ci-test/runs/4805180209?check_suite_focus=true
GitHub Actions - PowerShell: https://github.com/chawyehsu/bucket-gh-ci-test/runs/4805180122?check_suite_focus=true
AppVeyor: https://ci.appveyor.com/project/chawyehsu/bucket-gh-ci-test/builds/42190228
If a bucket was using AppVeyor for manifest testing, nothing needs to be changed. But if you want to migrate it to GitHub Actions, you'll need to setup the workflow manually for the bucket. Here is an example workflow.
Checklist: