[Bug] cleanup cannot delete old version

[zhangchaoza]

Bug Report

Current Behavior

After scoop cleanup *, there were nothing cleaned up.

$ scoop cleanup *
Everything is shiny now!

Expected Behavior

Should clear old version, such like

Removing pe-bear: _0.5.5.2.old

I found all the directories like "_$version.old" cannot be deleted.

Possible Solution

I changed function Get-InstalledVersion in lib\versions.ps1

return $versions | Where-Object { ($_ -ne 'current') -or ($_ -like '_*.old*') }

System details

Windows version: 10

OS architecture: 64bit

PowerShell version: 7.2.1

Additional software: [(optional)
Current Scoop version:
5602083 (HEAD -> master, tag: 2021-12-26, origin/master, origin/HEAD) fix(schema): Add 'license' definition (#4596)

[rashil2000]

@niheaven looks like this was added in #3721. Any reason for excluding *.old folders?

[niheaven]

It's not a bug of Get-InstalledVersion, it's a bug of scoop-cleanup, I'll fix it soon.

Emm, it should be fixed by add a new switch to Get-InstalledVersion...

Since _xxx.old is unused, so it is excluded from installed version, but if we want to clean up, it must be listed.