fix(versions): Get current version from failed installation if possible #4720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes some UX after #3721, which cause
scoop reset <app>
not works as before (some use cases that I missed)lib\versions.ps1
:Select-CurrentVersion()
now get version fromcurrent
folder or latest installed versionlib\install.ps1
:ensure_none_failed()
just reset failed app if it is installed successfully beforelib\core.ps1
:failed()
could figure out failed installation with newSelect-CurrentVersion()
functionlibexec\scoop-list.ps1
: Correctly mark failed applibexec\scoop-install.ps1
: Useensure_none_failed()
before installing appslibexec\scoop-update.ps1
: Useensure_none_failed()
before updating appsMotivation and Context
scoop reset
#4573scoop reset *
#4684How Has This Been Tested?
Remove
current
junction in7zip
Before:
After:
Checklist:
I have updated the tests accordingly.