[Bug] scoop in docker shims seem broken

[mjvankampen]

Bug Report

Current Behavior

install scoop in a docker container
install a scoop package (such as git)
use scoop package in a subsequent RUN command results in:

Could not create process with command '"C:\Users\ContainerAdministrator\scoop\apps\git\current\cmd\git.exe"  clone -q https://github.com/samuelcolvin/pydantic.git C:\Users\ContainerAdministrator\AppData\Local\Temp\pip-install-xmwtmaol\pydantic_4641e039e3774955b81c25db0d639f23'.

Expected Behavior

Can use installed programs

Additional context/output

Possible Solution

https://github.com/ScoopInstaller/Scoop/tree/2021-12-26 does work

System details

Windows version: 10

OS architecture: 64bit

PowerShell version: [output of "$($PSVersionTable.PSVersion)"]

Additional software: [(optional) e.g. ConEmu, Git]

Scoop Configuration

//# Your configuration here

I will try to add more config details asap, but maybe someone already has an idea?

[niheaven]

What if using shim? i.e., <scoopdir>\shims\git.exe to run the command.

[rashil2000]

Additionally, can you remove the double quotes in <scoopdir>\shims\git.shim file and try again? I have a feeling this regression is due to the double quotes, again

[hboomsma]

@rashil2000 @mjvankampen tested with the following Dockerfile, but removing the double quotes from the .shim file does not help

FROM mcr.microsoft.com/powershell:lts-windowsservercore-1809
SHELL ["pwsh","-C"]

RUN iwr -useb 'https://raw.githubusercontent.com/scoopinstaller/install/master/install.ps1' -outfile 'install.ps1'
RUN .\install.ps1 -RunAsAdmin
RUN scoop install minisign
RUN "echo \"path = C:\Users\ContainerAdministrator\scoop\apps\minisign\current\minisign.exe\" > C:\Users\ContainerAdministrator\scoop\shims\minisign.shim"
RUN type C:\Users\ContainerAdministrator\scoop\shims\minisign.shim
RUN minisign
CMD ["pwsh"]

Result:

[hboomsma]

@rashil2000 @mjvankampen
Found a broken link of some sort:

From the version directory it seems to work:

[niheaven]

So the current dir is broken or not linked?

[hboomsma]

Looks like it to me, but I'm not familiar with windows links:

[pd-kcarrasco]

We're being affected by the same issue as well. all Junctions created with New-Item -ItemType Junction are broken.
I think we need to revert this commit. junctions created with mklink work:

After building a container, run it and you can see junctions crated with new-item are missing their target:

# empty target from junction created with New-Item
PS C:\Users\ContainerAdministrator\scoop\apps\python37\3.7.9> (gi .\scripts_new-item\).Target

# target is present in junction created with mklink
PS C:\Users\ContainerAdministrator\scoop\apps\python37\3.7.9> (gi .\scripts_mklink\).Target
C:\Users\ContainerAdministrator\scoop\persist\python37\Scripts

[rashil2000]

What is your PowerShell version?

[charliedaveputh]

这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。

[kingster]

@rashil2000 Getting the same error.

PS C:\BuildTools> $PSversionTable

Name                           Value
----                           -----
PSVersion                      5.1.17763.1971
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17763.1971
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

[rashil2000]

Has this issue been reported to PowerShell upstream? I can't find it.

[kingster]

Not sure if this is a PowerShell issue. This used to work with the same PowerShell version till scoop-2021-12-26, I would also agree with @pd-kcarrasco that probably 98ea7a5 broke this

When I run the same command in powershell the links are properly created

PS C:\> New-Item -Path Users-link1 -ItemType Junction -Value Users


    Directory: C:\


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d----l        3/22/2022   7:34 PM                Users-link1


PS C:\> (gi .\Users-link1).Target

[rashil2000]

It seems to affect only docker containers, that's why I asked if there's a report of it somewhere upstream

[kingster]

docker/for-win#12240 Found this bug report, but seems like this was not fixed

[rashil2000]

Is there a way to recognize docker context (with help of an environment variable or something)? We can write a wrapper function for it as a workaround

[kingster]

Should be possible https://stackoverflow.com/a/46810471

[rashil2000]

Can you make a PR?
Ideally, we need a wrapper function New-DirectoryJunction in lib/install.ps1, which uses mklink if inside Docker, and falls back to New-Item -ItemType Junction otherwise.

[kingster]

Have attempted the fix in #4837. With that fix I was able to install it successfully inside a Dockerfile

[christopher-dG]

Thanks for the fix! Does scoop need a new release for users to get the new code?

[rashil2000]

Yes, we should probably create a small patch release for the recent bug fixes.
/cc @niheaven

[niheaven]

Of cause, in a few days, maybe.

[skeptic-monkey]

If we have to wait for couple of days, what would be the instruction to install scoop from the develop branch ?
This is blocking the CI/CD of my company, as I can't rebuid my containers.

[rashil2000]

scoop config SCOOP_BRANCH develop
scoop update

[rashil2000]

@niheaven could you please draft a patch release? It's been 4 weeks 😅