Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(reset_aliases): Move core function of reset_aliases to scoop #4794

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Mar 9, 2022

Description

reset_aliases is added since scoop uses lots of PS alias (md, cd, gci, etc.) during its early development, and this function reset all alias to PS's default.

Now Verb-Noun form of function names is used, so this is not needed.

The one added in scoop.ps1 is force use script (scoop) function instead of user-definded alias or function in global environment outsides scoop.

Additionally, ensure() is refactored and mkdir in test files are replaced by ensure()

How Has This Been Tested?

Passed tests.

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated/passed the tests accordingly.

@niheaven niheaven force-pushed the feature/refactor-reset_aliases branch from df66e52 to 9f8a591 Compare March 9, 2022 16:56
@niheaven niheaven requested review from chawyehsu and rashil2000 and removed request for chawyehsu March 11, 2022 06:25
@niheaven niheaven merged commit 5a795ca into develop Mar 11, 2022
@niheaven niheaven deleted the feature/refactor-reset_aliases branch March 11, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants