Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-info): Fix error message when manifest is not found #4935

Merged
merged 6 commits into from
May 17, 2022
Merged

fix(scoop-info): Fix error message when manifest is not found #4935

merged 6 commits into from
May 17, 2022

Conversation

quotidian-ennui
Copy link
Contributor

Description

Fixes #4928.

Abort message no longer references the last bucket searched via Find-Manifest

Motivation and Context

Fixes #4928

How Has This Been Tested?

This is an edge case abort message, and there appear to be no tests that use the string literal Could not find manifest which suggests the text is never explicitly matched against during test execution.

$ find . -name "*.ps1" -exec grep -iH "could not find manifest" {} \;
./libexec/scoop-home.ps1:        abort "Could not find manifest for '$app'."
./libexec/scoop-info.ps1:    abort "Could not find manifest for '$(show_app $app)' in any known buckets."

My assumption here is that the tests should pass, sadly I don't actually have a powershell build environment, and I wouldn't really know how to start building one to include BuildHelpers and other PS modules referenced in test/bin/test.ps1

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly. Documentation change not required.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Fixes #4928.

Abort message no longer references the last bucket searched via
Find-Manifest
libexec/scoop-info.ps1 Outdated Show resolved Hide resolved
Co-authored-by: HUMORCE <humorce@outlook.com>
@quotidian-ennui quotidian-ennui requested a review from HUMORCE May 17, 2022 14:33
HUMORCE
HUMORCE previously approved these changes May 17, 2022
niheaven
niheaven previously approved these changes May 17, 2022
@niheaven niheaven changed the title fix: error message when manifest not found using scoop info fix(scoop-info): Fix error message when manifest is not found May 17, 2022
@niheaven niheaven merged commit 47d7f76 into ScoopInstaller:develop May 17, 2022
@quotidian-ennui quotidian-ennui deleted the info_cosmetic_error branch May 17, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants