Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Deprecate tls1 and tls1.1 #4950

Merged
merged 1 commit into from
May 28, 2022

Conversation

neheb
Copy link
Contributor

@neheb neheb commented May 24, 2022

Both of these are deprecated.

@neheb
Copy link
Contributor Author

neheb commented May 24, 2022

The interesting thing on my Windows 8.1 machine is that TLS1.3 is available. So .Net 4.8 is installed?

@neheb
Copy link
Contributor Author

neheb commented May 24, 2022

Interestingly enough,

if (!($isNewerNetFramework -and $isSystemDefault)) {

evaluates to true on my machine. The weird thing is, [System.Net.ServicePointManager]::SecurityProtocol is set to SystemDefault. It shouldn't be evaluating to true and overwriting SystemDefault.

@issaclin32
Copy link
Member

issaclin32 commented May 26, 2022

Please change base branch to develop instead of master.

@neheb neheb changed the base branch from master to develop May 27, 2022 02:12
@neheb
Copy link
Contributor Author

neheb commented May 27, 2022

Done.

@niheaven
Copy link
Member

I'm not familiar with TLS and .net, but for Win 7 and .net 4.5, should this cause errors?

And if we update minimal requirement to .net 4.7, this TLS sector could be removed IMO.

@neheb
Copy link
Contributor Author

neheb commented May 27, 2022

.net 4.5 supports tls 1.2. There's no change here other than removing 1.0 and 1.1.

I will say that even this is not enough to fix ScoopInstaller/Main#3593 . Maybe the issue needs to be reported to curl developers.

@chawyehsu chawyehsu changed the title core.ps1: remove TLS1 and 1.1 chore(core): Deprecate tls1and tls1.1 May 27, 2022
chawyehsu
chawyehsu previously approved these changes May 27, 2022
@chawyehsu
Copy link
Member

Update CHANGELOG please.

@chawyehsu chawyehsu changed the title chore(core): Deprecate tls1and tls1.1 chore(core): Deprecate tls1 and tls1.1 May 27, 2022
@neheb
Copy link
Contributor Author

neheb commented May 27, 2022

Done.

@niheaven niheaven merged commit 2e52888 into ScoopInstaller:develop May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants