-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): Deprecate tls1 and tls1.1 #4950
Conversation
The interesting thing on my Windows 8.1 machine is that TLS1.3 is available. So .Net 4.8 is installed? |
Interestingly enough,
evaluates to true on my machine. The weird thing is, [System.Net.ServicePointManager]::SecurityProtocol is set to SystemDefault. It shouldn't be evaluating to true and overwriting SystemDefault. |
Please change base branch to |
Done. |
I'm not familiar with TLS and .net, but for Win 7 and .net 4.5, should this cause errors? And if we update minimal requirement to .net 4.7, this TLS sector could be removed IMO. |
.net 4.5 supports tls 1.2. There's no change here other than removing 1.0 and 1.1. I will say that even this is not enough to fix ScoopInstaller/Main#3593 . Maybe the issue needs to be reported to curl developers. |
Update CHANGELOG please. |
IETF in 2021 deprecated these. See: https://datatracker.ietf.org/doc/html/rfc8996
Done. |
Both of these are deprecated.