Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Allow to use '_' and '.' in bucket name #4952

Merged
merged 2 commits into from
May 25, 2022
Merged

fix(core): Allow to use '_' and '.' in bucket name #4952

merged 2 commits into from
May 25, 2022

Conversation

topstone
Copy link
Contributor

Description

Updating a bucket is always failed when bucket name contains '_' or '.'.

(Scoop v0.2.0 - Released at 2022-05-10)

Motivation and Context (How to reproduce the error)

> scoop bucket add aaa_bbb SOME-REPO-URL
Checking repo... OK
The aaa_bbb bucket was added successfully.
> scoop update SOME-MANIFEST-IN-REPO-AAA_BBB
Couldn't find manifest for 'aaa_bbb'.

How Has This Been Tested?

Sorry for no tests, no docs. I'm not good at PowerShell, just found out where to fix.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Updating a bucket is always failed when bucket name includes '_' or '.'.
rasa
rasa previously approved these changes May 25, 2022
@niheaven
Copy link
Member

Please update the changelog

@topstone
Copy link
Contributor Author

Updated 'CHANGELOG.md'. Please review it.

@niheaven niheaven merged commit ad04dc9 into ScoopInstaller:develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants