Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(manifest): Rename 'Find-Manifest()' to 'Get-Manifest()' #4966

Merged
merged 2 commits into from
Jun 7, 2022
Merged

refactor(manifest): Rename 'Find-Manifest()' to 'Get-Manifest()' #4966

merged 2 commits into from
Jun 7, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jun 4, 2022 •
edited
Loading

Description

  • Move bucket.ps1/Find-Manifest() to manifest.ps1/Get-Manifest()
  • Embed parse_app() into Get-Manifest()
  • Enclose parse_app()'s RegEx with ^ and $

Motivation and Context

How Has This Been Tested?

  • scoop cat
  • scoop info
  • scoop home
  • scoop install
  • test.ps1

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven
Copy link
Member Author

niheaven commented Jun 6, 2022

Merge and test?

@niheaven niheaven merged commit ccd067b into develop Jun 7, 2022
@niheaven niheaven deleted the refactor-get-maifest branch June 7, 2022 01:31
@chawyehsu chawyehsu mentioned this pull request Jun 10, 2022
Merged
@niheaven niheaven mentioned this pull request Jun 10, 2022
Merged
@rashil2000 rashil2000 mentioned this pull request Jun 10, 2022
Closed
@niheaven niheaven mentioned this pull request Jun 13, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000