Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builds(json): Update Newton.Json to 13.0.1 #5026

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jul 1, 2022

Description

Update Newton.Json to v13.0.1, .NET Compiler to v4.2.0

Motivation and Context

Relates to https://github.com/ScoopInstaller/Scoop/security/dependabot/1

How Has This Been Tested?

Core test and buckets test are passed.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

rashil2000
rashil2000 previously approved these changes Jul 1, 2022
@niheaven niheaven merged commit 76c3bcd into develop Jul 1, 2022
@niheaven niheaven deleted the update-newton.json branch July 1, 2022 14:29
slaughtering pushed a commit to slaughtering/scoop that referenced this pull request Jul 7, 2022
@rashil2000
Copy link
Member

@niheaven
Copy link
Member Author

Disable the Windows PowerShell one, since that test only checks manifest completness and the PowerShell check is enough.

For Scoop Core, both are needed.

@rashil2000
Copy link
Member

Disable the Windows PowerShell one, since that test only checks manifest completness and the PowerShell check is enough.

I don't think we should do this. Have the NewtonSoft devs officially deprecated Windows PowerShell? It is still the default installed one in latest Windows versions and anyone who would want to run tests locally would not be able to do so.

@niheaven
Copy link
Member Author

This is because the default package version of Newtonsoft.Json used in Newtonsoft.Json.Schema 3.0.14 is 12.0.0.0 and has not been updated to 13.0.0.0, and Windows PowerShell could not load Newtonsoft.Json.Schema while PowerShell could.

I'm searching for solutions but could not found a plug-and-play one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants