-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builds(json): Update Newton.Json to 13.0.1 #5026
Conversation
Windows PowerShell tests in buckets are failing for some reason after this change, see https://github.com/ScoopInstaller/Extras/runs/7258964834?check_suite_focus=true and https://github.com/ScoopInstaller/Main/runs/7251837120?check_suite_focus=true |
Disable the Windows PowerShell one, since that test only checks manifest completness and the PowerShell check is enough. For Scoop Core, both are needed. |
I don't think we should do this. Have the NewtonSoft devs officially deprecated Windows PowerShell? It is still the default installed one in latest Windows versions and anyone who would want to run tests locally would not be able to do so. |
This is because the default package version of Newtonsoft.Json used in Newtonsoft.Json.Schema 3.0.14 is 12.0.0.0 and has not been updated to 13.0.0.0, and Windows PowerShell could not load Newtonsoft.Json.Schema while PowerShell could. I'm searching for solutions but could not found a plug-and-play one... |
Description
Update Newton.Json to v13.0.1, .NET Compiler to v4.2.0
Motivation and Context
Relates to https://github.com/ScoopInstaller/Scoop/security/dependabot/1
How Has This Been Tested?
Core test and buckets test are passed.
Checklist:
develop
branch.