-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(download): Rename dl()
to Invoke-Download()
#5143
Conversation
dl
to Invoke-WebDownload
dl
to Invoke-WebDownload
dl
to Invoke-WebDownload
dl()
to Invoke-WebDownload()
I think |
Thanks for the feedback @niheaven. I have a few clarifying questions:
@@ -4,6 +4,7 @@
"powershell.codeFormatting.preset": "OTBS",
"powershell.codeFormatting.alignPropertyValuePairs": true,
"powershell.codeFormatting.ignoreOneLineBlock": true,
+ "powershell.codeFormatting.useConstantStrings": true,
"files.exclude": {
"**/.git": true,
"**/.svn": true, |
Yes, it should, but in fact this file is no longer used. Now installer script is here in https://github.com/ScoopInstaller/Install.
Yes, it is, and we usually use the following setting too: "powershell.codeFormatting.useCorrectCasing": true |
dl()
to Invoke-WebDownload()
dl()
to Invoke-Download()
@examosa Can you make a corresponding PR to GithubActions too? Otherwise the actions will break when this feature gets released. |
Description
This PR renames the
dl
and related functions to use more descriptive names that better adhere to PowerShell conventions.Motivation and Context
Resolves #3830
How Has This Been Tested?
Test suite run on local machine and in CI; all remain passing.
Checklist:
develop
branch.