feat(core): Add -Quiet switch for Invoke-ExternalCommand
#5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niheaven
reviewed
Jan 20, 2023
|
Ed. LGTM except for the param name. Hmm, renaming to
|
|
@niheaven Fair point. Will do. |
Done. |
niheaven
approved these changes
Mar 11, 2023
lewis-yeung
changed the title
-Silent switch for Invoke-ExternalCommand-Quiet switch for Invoke-ExternalCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In function
Invoke-ExternalCommand, the$Process.StartInfo.CreateNoWindowwas forcibly set to$trueby mistake in #5066, which may cause problems in some cases. In this PR, a-Silent-Quietswitch was introduced. The switch controls whether an app should run silently, that means, without any output for a console app or without a window for a GUI app.Checklist:
developbranch.