Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix scripts' calling parameters #5365

Merged
merged 3 commits into from
Feb 26, 2023
Merged

fix(core): Fix scripts' calling parameters #5365

merged 3 commits into from
Feb 26, 2023

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jan 30, 2023 •
edited
Loading

Description

Direct calling of scoop scripts makes getopt() error, since it bypassed PowerShell's arguments parsing.

So use splatting to pass arguments correctly (w/o splitting by space).

Motivation and Context

How Has This Been Tested?

Should be fine and tested by scoop import

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven merged commit 3f11454 into develop Feb 26, 2023
@niheaven niheaven deleted the fix-scoop-import branch February 26, 2023 06:31
@niheaven niheaven mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000