Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] scoop install/update breaks on a cosmetic error message (gsudo) #5597

Closed
yonizaf opened this issue Jul 31, 2023 · 2 comments · Fixed by #5424
Closed

[Bug] scoop install/update breaks on a cosmetic error message (gsudo) #5597

yonizaf opened this issue Jul 31, 2023 · 2 comments · Fixed by #5424
Labels

Comments

@yonizaf
Copy link

yonizaf commented Jul 31, 2023

Bug Report

While installing or updating gsudo as global install, an error message is shown:
Installing PowerShell modules globally is not implemented!
This is fine. it's a cosmetic message (or should be) and does not affect the use of gsudo.
However, the scoop install script dies at this point, leaving a partial 'failed' install, and does not continue to install/update further packages (requested by the same command).

This is not a gsudo-specific issue. I opened an issue in the main bucket repo (ScoopInstaller/Main#4989), it was closed and I was directed to open one here.

Current Behavior

Run scoop install -g gsudo something somethingelse.
gsudo is installed correctly, however scoop lists it as failed install.
furthermore, scoop does not try to install something and somethingelse. The install script simply dies silently.

Expected Behavior

  1. Ignore unimportant error messages and finalize install of gsudo.
  2. move forward to update the next package even if one package update failed.

Additional context/output

> scoop status
Scoop is up to date.

Name           Installed Version Latest Version Missing Dependencies Info
----           ----------------- -------------- -------------------- ----
gsudo          2.0.4             2.3.0
mingit-busybox 2.39.1.windows.1  2.41.0.3

> scoop update -g *
gsudo: 2.0.4 -> 2.3.0 (global)
mingit-busybox: 2.39.1.windows.1 -> 2.41.0.3 (global)
Updating 2 outdated apps:
Updating 'gsudo' (2.0.4 -> 2.3.0)
Downloading new version
gsudo.setup.x64.msi (2.2 MB) [================================================================================] 100%
Checking hash of gsudo.setup.x64.msi ... ok.
Uninstalling 'gsudo' (2.0.4)
Removing shim 'sudo.shim'.
Removing shim 'sudo.exe'.
Unlinking C:\ProgramData\scoop\apps\gsudo\current
Installing 'gsudo' (2.3.0) [64bit] from main bucket
Loading gsudo.setup.x64.msi from cache
Extracting gsudo.setup.x64.msi ... done.
Linking C:\ProgramData\scoop\apps\gsudo\current => C:\ProgramData\scoop\apps\gsudo\2.3.0
Creating shim for 'sudo'.
Installing PowerShell modules globally is not implemented!

> scoop status
Scoop is up to date.

Name           Installed Version Latest Version Missing Dependencies Info
----           ----------------- -------------- -------------------- ----
gsudo          2.0.4             2.3.0
mingit-busybox 2.39.1.windows.1  2.41.0.3

> gsudo -V
gsudo v2.3.0 (Branch.tags-v2.3.0.Sha.c7c3c9380a70bd004c4a3bebe9f54b86d836afbd)
Copyright(c) 2019-2022 Gerardo Grignoli and GitHub contributors

Possible Solution

System details

Windows version: 10, 11 (tested on both)

OS architecture: 64bit

PowerShell version: 7.2.13

Additional software: [(optional) e.g. ConEmu, Git]

Scoop Configuration

{
  "last_update": "2023-07-27T12:38:48.0797343+03:00",
  "scoop_repo": "https://github.com/ScoopInstaller/Scoop",
  "scoop_branch": "master"
}
@Lutra-Fs
Copy link
Contributor

Lutra-Fs commented Aug 4, 2023

Maybe #4135 could help on the issue that updates has been blocked?

@rashil2000
Copy link
Member

Installing global PSModules is tracked here: #5601
Continuing after a failed installation is tracked here: #4135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants