[Bug] getopt.ps1 splits literal strings and full file paths into multiple strings

[BinToss]

Linked Issues: #5313, #5326

Bug Report

Current Behavior

Scoop/libexec/scoop-shim.ps1

Line 49 in f930280

$opt, $other, $err = getopt $Args 'g' 'global'

Scoop/lib/getopt.ps1

Line 28 in f930280

$argv = @($argv -split ' ')

When a quoted string is present in $Args, it is treated as one string. get-opt.ps1 does not check for quoted strings and will split them if they contain spaces.

Expected Behavior

A path containing spaces should not be split if it is enclosed with single- or double-quotes.

test with...

scoop shim add edge 'C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe' '--' --global

Additional context/output

Possible Solution

Splitting arguments by spaces is redundant. The $Args variable is an array of strings which have already been split by whitespace. Doing so again is redundant and can lead to issues like this one.
I recommend requiring users to enclose an arguments in in quotes if it must contain whitespace.

System details

Windows version	11
OS architecture	64bit
PowerShell version	7.3.7

Scoop Configuration

{
  "last_update": "2023-10-11T02:06:48.3814390-07:00",
  "alias": {
    "upgrade": "scoop-upgrade"
  },
  "scoop_repo": "https://github.com/ScoopInstaller/Scoop",
  "scoop_branch": "master"
}

[hagaigold]

look like #5313 / #5326

[BinToss]

Ah, yes. It is a duplicate. I wonder why I those didn't turn up when I searched for existing issues...

Close this as Duplicate?

[hagaigold]

Ah, yes. It is a duplicate. I wonder why I those didn't turn up when I searched for existing issues...

you can switch to the develop branch, if you don't mind using the not released version:

scoop config scoop_branch develop