Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json): Serialize jsonpath return #5921

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

chawyehsu
Copy link
Member

@chawyehsu chawyehsu commented Apr 24, 2024

This may break checkver of some manifests if they leverage the old format of return. We can update those manifests once found.

Description

Motivation and Context

Closes #5920

Relates to #XXXX

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
@niheaven
Copy link
Member

In the given example, json_path will yield [[17,50,19,0],"87c7b863-4be0-4324-ab84-dfde19bccc18",[17,50,19,0],"12ad915b-781e-4859-aedb-2d1e51f9d384"]. Can this be easily handled subsequently?

@chawyehsu
Copy link
Member Author

The output will be handled by the specified regex next to the jsonpath, so it's up to the manifest author. I believe it'd help to write simpler regex by yielding such clean json output.

@niheaven niheaven merged commit 3b34497 into ScoopInstaller:develop Apr 26, 2024
2 checks passed
brian6932 pushed a commit to brian6932/Scoop that referenced this pull request Jun 1, 2024
niheaven pushed a commit that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants