Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-info): Fix download size estimating #5958

Merged
merged 2 commits into from
May 11, 2024
Merged

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented May 11, 2024

Description

In certain scenarios, the estimated download size may be incorrect.

Motivation and Context

How Has This Been Tested?

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Sorry, something went wrong.

niheaven added 2 commits May 11, 2024 16:49

Verified

This commit was signed with the committer’s verified signature.
niheaven Hsiao-nan Cheung

Verified

This commit was signed with the committer’s verified signature.
niheaven Hsiao-nan Cheung
@niheaven niheaven merged commit b710ff6 into develop May 11, 2024
2 checks passed
@niheaven niheaven deleted the fix-scoop-info branch May 11, 2024 10:22
brian6932 pushed a commit to brian6932/Scoop that referenced this pull request Jun 1, 2024

Partially verified

This commit is signed with the committer’s verified signature.
brian6932’s contribution has been verified via SSH key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
niheaven added a commit that referenced this pull request Jun 30, 2024

Verified

This commit was signed with the committer’s verified signature.
niheaven Hsiao-nan Cheung
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant