Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checkver): Correct error messages #6024

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(checkver): Correct error messages #6024

merged 1 commit into from
Jun 25, 2024

Conversation

lewis-yeung
Copy link
Contributor

Description

When checking update and the $script is used, an error message should mention the output of script instead of $url.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

niheaven
niheaven reviewed Jun 24, 2024
View reviewed changes
bin/checkver.ps1 Outdated Show resolved Hide resolved
@niheaven niheaven merged commit d8b3cc8 into ScoopInstaller:develop Jun 25, 2024
2 checks passed
@lewis-yeung lewis-yeung deleted the fix-checkver branch June 25, 2024 02:52
@niheaven niheaven mentioned this pull request Jun 30, 2024
Merged
niheaven pushed a commit that referenced this pull request Jun 30, 2024
@lewis-yeung @niheaven
fix(checkver): Correct error messages (#6024)
1b6b9e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven niheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewis-yeung @niheaven