[Bug] Search command errors if JSON file has array as root element

[akarel-mb]

Bug Report

Current Behavior

In the event that a bucket is added that includes JSON files with an Array as the root element the scoop search command will throw an error for every offending file.

Expected Behavior

JSON files with arrays as root elements will be skipped

Additional context/output

MethodInvocationException: C:\...\scoop\apps\scoop\current\libexec\scoop-search.ps1:38
Line |
  38 |      if (!$json.RootElement.TryGetProperty('bin', [ref] $bin)) { retur …
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Exception calling "TryGetProperty" with "2" argument(s): "The requested operation requires an element of type 'Object', but the target element
     | has type 'Array'."

Possible Solution

Adding the following on the first line of the bin_match_json method in scoop-search.ps1 will skip JSON files with arrays as root elements.

if ($json.RootElement.ValueKind -eq [System.Text.Json.JsonValueKind]::Array) { return $false }

System details

Windows version: 11

OS architecture: 64bit

PowerShell version: 7.4.6

Scoop Configuration

{
  "last_update": "2024-12-03T10:55:10.7777953-05:00",
  "scoop_branch": "master",
  "scoop_repo": "https://github.com/ScoopInstaller/Scoop"
}

[akarel-mb]

Might make sense to add a more robust JSON validation method to catch similar issues like #6149