Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a release compatible with OpenZeppelin 5.x #61

Open
apbendi opened this issue Oct 16, 2023 · 0 comments
Open

Create a release compatible with OpenZeppelin 5.x #61

apbendi opened this issue Oct 16, 2023 · 0 comments

Comments

@apbendi
Copy link
Member

apbendi commented Oct 16, 2023

Since OpenZeppelin has released version 5.0.0 of their contracts, which includes changes to the Governor contracts, we should update Flexible Voting as-needed for compatibility with this release and tag a release of our own.

Of particular note to pay attention to is the addition of a nonce for voting with params, which came in direct response to our reporting of the replay vulnerability found in FV by Trail of Bits during the Frax governance audit. Since OZ has added this, it may be the case we can remove it from our FV implementation altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant