Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pagination on &find #4

Open
ScoreUnder opened this issue Jan 13, 2020 · 3 comments
Open

Allow pagination on &find #4

ScoreUnder opened this issue Jan 13, 2020 · 3 comments

Comments

@ScoreUnder
Copy link
Owner

No description provided.

@Brod8362
Copy link
Contributor

Should pagination be restricted to only the owner of the message, or should anyone be allowed to do it? (Should the option to use either be available?)

Should the message go away after X seconds since creation, or X seconds since last interaction? And, what should X be?

What are some other cases that should be considered regarding the behavior of the paginated message?

@Brod8362
Copy link
Contributor

Brod8362 commented Jan 27, 2020

Also, small todo list:

  • Message can be created and interacted with
  • Message reactions clear after specified time, or add a clock emoji to represent time's up
  • Either schedule task for disabling the interaction after a certain time, or do it after a certain period of inactivity
  • Remove the related object to prevent memory leak
  • Paginated messages must be compatible with the message blame system
  • Help command must retain compatibility with message editing functionality

@ScoreUnder
Copy link
Owner Author

Should pagination be restricted to only the owner of the message, or should anyone be allowed to do it? (Should the option to use either be available?)

I think owner only is the sensible thing here. You can also re-use the same mechanism that the &blame command uses to find this out, if necessary.

Should the message go away after X seconds since creation, or X seconds since last interaction? And, what should X be?

The message should just stay, I think.

The original message should be edited to reflect the newly requested page.

If you mean the interactivity/reactions, I don't know. 5 minutes from last interaction seems reasonable but that's just a totally arbitrary figure.

What are some other cases that should be considered regarding the behavior of the paginated message?

Not invoking the behaviour twice when the message is edited (current closest thing to pagination is in things like &help, and you can edit to &help 2 and the bot will edit its response in kind).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants