Resolves FoundationDB#3045: Require FileOptions to be first block of yamsql

Author: ScottDugas

yaml-tests/src/main/java/com/apple/foundationdb/relational/yamltests/YamlRunner.java

@@ -99,14 +99,16 @@ public void run() throws Exception {
         final var yaml = new Yaml(new CustomYamlConstructor(loaderOptions), new Representer(dumperOptions), new DumperOptions(), loaderOptions, new Resolver());
 
         final var testBlocks = new ArrayList<TestBlock>();
+        int blockCount = 0;
         try (var inputStream = getInputStream(resourcePath)) {
             for (var doc : yaml.loadAll(inputStream)) {
-                final var block = Block.parse(doc, executionContext);
+                final var block = Block.parse(doc, executionContext, blockCount);
                 logger.debug("⚪️ Executing block at line {} in {}", block.getLineNumber(), resourcePath);
                 block.execute();
                 if (block instanceof TestBlock) {
                     testBlocks.add((TestBlock) block);
                 }
+                blockCount++;
             }
         }
         for (var block : executionContext.getFinalizeBlocks()) {

yaml-tests/src/main/java/com/apple/foundationdb/relational/yamltests/block/Block.java

@@ -48,8 +48,9 @@ public interface Block {
      *
      * @param document a region in the file
      * @param executionContext information needed to carry out the execution
+     * @param blockCount the number of previous blocks in the file
      */
-    static Block parse(@Nonnull Object document, @Nonnull YamlExecutionContext executionContext) {
+    static Block parse(@Nonnull Object document, @Nonnull YamlExecutionContext executionContext, final int blockCount) {
         final var blockObject = Matchers.map(document, "block");
         Assert.thatUnchecked(blockObject.size() == 1, "Illegal Format: A block is expected to be a map of size 1");
         final var entry = Matchers.firstEntry(blockObject, "block key-value");
@@ -63,6 +64,8 @@ static Block parse(@Nonnull Object document, @Nonnull YamlExecutionContext execu
             case SetupBlock.SchemaTemplateBlock.SCHEMA_TEMPLATE_BLOCK:
                 return SetupBlock.SchemaTemplateBlock.parse(lineNumber, entry.getValue(), executionContext);
             case FileOptions.OPTIONS:
+                Assert.thatUnchecked(blockCount == 0,
+                        "File level options must be the first block, but found one at line " + lineNumber);
                 return FileOptions.parse(lineNumber, entry.getValue(), executionContext);
             default:
                 throw new RuntimeException("Cannot recognize the type of block");