Skip to content
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.

Better robustness regarding internet connection #47

Open
nitsanshai opened this issue Jun 20, 2016 · 2 comments
Open

Better robustness regarding internet connection #47

nitsanshai opened this issue Jun 20, 2016 · 2 comments

Comments

@nitsanshai
Copy link

More of an idea: since you're hitting the endpoint so many separate times, and since the script takes so long, it sucks when it fails for maybe a small disconnection because of the internet and none of the results you had accumulated so far get written. Maybe think about how to catch failures, maybe with exponential backoff on retries, and possibly after a certain amount of failures, save what the script has collected so far. Thoughts?

@justingallagher
Copy link
Contributor

@yiblet Can you add this as part of your parallel code? You should be able to just add a try-catch around this line in aggregate.py, where you retry on failure a certain number of times before aborting.

@yiblet
Copy link
Contributor

yiblet commented Jun 21, 2016

@justingallagher I already put in the pull request before I read this issue. I'll add on to it tomorrow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants