Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a monorepo style for extensions? #38

Closed
perrygoy opened this issue Jan 12, 2023 · 2 comments
Closed

Use a monorepo style for extensions? #38

perrygoy opened this issue Jan 12, 2023 · 2 comments
Assignees
Labels

Comments

@perrygoy
Copy link
Member

Having just made ~a half dozen almost-identical PRs to update copyright years and dependencies across all the ScreenPy ecosystem, i kinda don't want to have to do that again. I also noticed that all of our repos are a little tiny bit different—not on purpose, but because it's hard to set up 8 different repos exactly the same way. Some are missing Poetry; some were missing the ScreenPy-Maintainers group; some don't have Github checks...

It would be nice to have all that meta stuff handled in one spot. Maybe with Poetry we can support a monorepo environment with multiple packages deployed out of this repo?

Investigate!

@perrygoy perrygoy added the spike label Jan 12, 2023
@perrygoy perrygoy self-assigned this Jan 12, 2023
@perrygoy
Copy link
Member Author

looks like Poetry currently doesn't support a monorepo structure out of the box, but there is some interest in it and it's possible to bend its will to do it:
python-poetry/poetry#936
python-poetry/poetry#2270

here's a blog post and an example repo from someone who got it to work
https://gerben-oostra.medium.com/python-poetry-mono-repo-without-limitations-dd63b47dc6b8
https://gitlab.com/gerbenoostra/poetry-monorepo/

@perrygoy
Copy link
Member Author

perrygoy commented Feb 3, 2023

After thinking about it some more, part of the benefit to splitting the repos out like this is to "live by our own example"—part of the joy of ScreenPy and composition in general is how you can extend it additively, and all of the supported extensions living in their own repos is meant to show how to do that.

So, despite the extra work, i still think this is the right way to do it. Closing!

@perrygoy perrygoy closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant