Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: documentation clarification: named routes #55

Closed
difuoan opened this issue Feb 11, 2019 · 4 comments
Closed

[fix]: documentation clarification: named routes #55

difuoan opened this issue Feb 11, 2019 · 4 comments
Labels
Milestone

Comments

@difuoan
Copy link

difuoan commented Feb 11, 2019

Just wanted to say that I spend multiple hours trying to figure out why the plugin was mixing up my route-params. Turns out because I used named routes, which seem to clash with the plugin for some reason.

This is not really documented, which would have been great for me, and very likely will be for others in the future.

@Scrum
Copy link
Owner

Scrum commented Feb 12, 2019

@difuoan Hi, thanks for feedback, can you set an example?

@Scrum Scrum pinned this issue Feb 12, 2019
@kavayzin
Copy link

kavayzin commented Mar 21, 2019

@difuoan, @Scrum We had a similar problem. Here is an example: http://jsfiddle.net/qbw0douh/1/.
Description of the problem:
after clicking on the link which contains the named parameter, all other links become invalid.
For example, after clicking on a link, the parameter "entityName" in which is equal to "entity1", this code is
<router-link: to = "{name: 'entities', params: {entityName: 'entity2'}}"> entities 2 < / router-link>
generates the following
<a href="/settings/entities/entity1" class="router-link-active"> entities 2 </a>
tag

The problem is solved when I comment on the following line https://github.com/Scrum/vue-2-breadcrumbs/blob/master/src/vue-2-breadcrumbs.js#L11, but I don’t know how correct this solution will be

@Scrum Scrum added the bug label Mar 21, 2019
@Scrum Scrum changed the title documentation clarification: named routes [bug]: documentation clarification: named routes Mar 21, 2019
@Scrum Scrum changed the title [bug]: documentation clarification: named routes [fix]: documentation clarification: named routes Mar 21, 2019
@Scrum Scrum unpinned this issue Mar 21, 2019
@Scrum Scrum added this to the 0.5.1 milestone Mar 21, 2019
@Scrum
Copy link
Owner

Scrum commented Mar 21, 2019

@kavayzin Hi, thanks for feedback, I will try to solve it soon.

@Scrum Scrum closed this as completed in cd41adc Jun 24, 2019
@Scrum
Copy link
Owner

Scrum commented Jun 24, 2019

@difuoan @kavayzin Done, I regret the lack of time to solve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants