Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #16

Open
jokuNimi opened this issue Jun 6, 2023 · 1 comment
Open

Refactoring #16

jokuNimi opened this issue Jun 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jokuNimi
Copy link

jokuNimi commented Jun 6, 2023 •
edited
Loading

Hi. I'm considering implementing the feature request #4. In issue #14 SeaDve says

I would like to mention though that Breathing's animation and timer code is very hacky and not very extensible. I did have plans on major refactoring, but haven't got that time yet.

What sort of refactoring did you (SeaDve) have in mind, and do you think that should be done before implementing new features? It looks like some refactoring is needed in any case, and I could do something a bit fancier if I end up doing some refactoring anyway.

PS. Feel free to close this issue, since it's not really an issue. This was just the easiest way for me to ask a question.
@SeaDve
Copy link
Owner

SeaDve commented Jun 6, 2023 •
edited
Loading

Thanks for looking forward to contribute!

One of the first step as far as I remember is to do the animation using AdwAnimation and GtkSnapshot APIs. This would give a lot more control compared to using css classes.

@SeaDve SeaDve added the enhancement New feature or request label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jokuNimi @SeaDve