Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose order_by_with_nulls in QueryOrder trait #2227

Closed
IgnisDa opened this issue May 16, 2024 · 3 comments · Fixed by #2228
Closed

Expose order_by_with_nulls in QueryOrder trait #2227

IgnisDa opened this issue May 16, 2024 · 3 comments · Fixed by #2228

Comments

@IgnisDa
Copy link
Contributor

IgnisDa commented May 16, 2024

I would like to order by <col> nulls last in my query but am unable to since that method is not exposed.
@IgnisDa
Copy link
Contributor Author

IgnisDa commented May 16, 2024

@tyt2y3 Would you be willing to accept a PR for this?

@IgnisDa IgnisDa mentioned this issue May 16, 2024
Closed
@tyt2y3
Copy link
Member

tyt2y3 commented May 16, 2024

sure!

@IgnisDa IgnisDa mentioned this issue May 16, 2024
Merged
@IgnisDa
Copy link
Contributor Author

IgnisDa commented May 20, 2024

@tyt2y3 Could you take a look at the PR I made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add function to allow order by nulls
2 participants
@tyt2y3 @IgnisDa