Postgres TIMESTAMP WITH TIMEZONE (TIMESTAMPTZ) support

[ShawnROGrady]

Currently there is only a Value::DateTime variant which does not work for TIMESTAMP WITH TIMEZONE (TIMESTAMPTZ) column types.

[billy1624]

Hi, thanks for the issue! What is your suggestions on this?

Perhaps we can add Value::DateTimeTz that is timezone aware?

pub enum Value {
    #[cfg(feature = "with-chrono")]
    DateTimeTz(Box<chrono::DateTime>),
    // ...
}

[ShawnROGrady]

@billy1624 hi, that was my initial thought but I wasn't sure how well that would translate across the other dialects you support (mysql, sqlite) since postgres is what I'm most familiar with. Adding an additional enum variant seems like the clearest solution to me assuming other dialects have something analogous to TIMESTAMPTZ.

Thanks!

[billy1624]

Yes, @ShawnROGrady, good point! We have to also consider the TIMESTAMPTZ support on other databases.

[billy1624]

Currently there is only a Value::DateTime variant which does not work for TIMESTAMP WITH TIMEZONE (TIMESTAMPTZ) column types.

The problem is that Value::DateTime will produce a datetime string that does not have timezone suffix? i.e. "2021-07-27 16:48:00".

However, what you need for updating / inserting a TIMESTAMPTZ column is something like "2021-07-27 16:48:00+08"?

Correct me if I am wrong. Thanks!!

Ref: https://www.postgresql.org/docs/9.1/datatype-datetime.html

[tyt2y3]

@billy1624 I think your understanding of the problem is correct.

[tyt2y3]

I suggest adding a variant to Value called DateTimeWithTimeZone

[forrest-akin]

Similarly, Time is missing a corresponding TimeTz

[tyt2y3]

0.12.9
@ShawnROGrady please re-open this issue if you find any issues.
@forrest-akin please open a new issue if you needed that.