Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: google map language to default to LOCALE_ID #1754

Merged
3 commits merged into from Nov 5, 2019
Merged

feat: google map language to default to LOCALE_ID #1754

3 commits merged into from Nov 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2019

the language of google maps should default to angular's LOCALE_ID, and not en-US

…le maps should default to angular's LOCALE_ID, andnot en-US
@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #1754 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   49.86%   50.02%   +0.15%     
==========================================
  Files          43       43              
  Lines        1903     1905       +2     
  Branches      170      171       +1     
==========================================
+ Hits          949      953       +4     
+ Misses        950      948       -2     
  Partials        4        4
Impacted Files Coverage Δ
...e/services/maps-api-loader/lazy-maps-api-loader.ts 89.39% <100%> (+3.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57685f2...dc864a0. Read the comment docs.

@ghost ghost requested a review from msenosiain November 4, 2019 17:15
@ghost ghost merged commit 56a858e into sebholstein:master Nov 5, 2019
@ghost ghost deleted the localeid-language branch November 6, 2019 09:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants