feat(SebmGoogleMap): Add missing inputs for control options #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I'm not sure why we're still using I find decorators very good with "and don't forget to include the name of this over there", where the roles are reversed: you specifically say "include this over there". I've already mentioned this, and a similar strategy for similar problems, in #767. Of course, I'm not criticizing you or this PR in any way. It was just a good timing to mention this again. :) |
|
@lazarljubenovic Agreed. |
|
@jinder @lazarljubenovic I would also like to use @input decorators but the docs generator is not able to detect properties with @input or @output decorators atm. I will have to check if can display this in another way. Will merge this PR now |
franknwankwo
pushed a commit
to caravancoop/angular2-google-maps
that referenced
this pull request
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SebastianM Sorry, forgot the actual inputs!