feat(polylines): add support for Polylines #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
andir
force-pushed
the
add-polyline
branch
2 times, most recently
from
b49e175
to
0664f23
Compare
andir
changed the title
andir
changed the title
|
@andir thank you! I will add some comments this weekend but that looks very good already 👍 |
| */ | ||
| lineRightClick: EventEmitter<PolyMouseEvent> = new EventEmitter<PolyMouseEvent>(); | ||
|
|
||
| @ContentChildren(SebmGoogleMapPolylinePoint) _points: QueryList<SebmGoogleMapPolylinePoint>; |
|
@andir Review ready |
|
Thank you @SebastianM |
|
|
||
| let polylineId = 0; | ||
| /** | ||
| * SebmGoogleMapPolyline renders a polyline on a { |
|
Thank you @andir . Added one little comment. Then I will test it (and when I find no bugs, merge it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Polylines on google maps.
Since angular2's QueryLists do not yet implement the
Observableinterface (https://angular.io/docs/js/latest/api/core/index/QueryList-class.html) the amount of polygons can't really change after initial creation.