Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_authenticatedRequest can be used only for GET requests. #348

Closed
yairiff opened this issue Jul 22, 2024 · 1 comment · Fixed by #352
Closed

_authenticatedRequest can be used only for GET requests. #348

yairiff opened this issue Jul 22, 2024 · 1 comment · Fixed by #352

Comments

@yairiff
Copy link

yairiff commented Jul 22, 2024

There are features in the Cloud API that are not available through this package, so it is handy to have the ability to send authenticated requests to Meta without re-exposing the token (I specifically do message template registration).

The problem is that there is no way to define the method, only the url and other headers.
Just add the ability to control all the request options, rather than only headers.

@Secreto31126
Copy link
Owner

Hi!

I find this topic to be a little controversial, as I don't like giving lead way for accidentally exposing the API key (such as fetching a malicious endpoint). However, it would also be nice to have the utility integrated in the class for more specific use cases.

I guess I can implement it for v4 and leave it well clarified in the documentation about the risks of the method. Maybe a more unusual name such as a $$ prefix might also help.

Thanks for the idea!

@Secreto31126 Secreto31126 mentioned this issue Aug 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants