Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for accounts in the derivation path #17

Closed
newtonick opened this issue Jun 11, 2021 · 4 comments
Closed

Add support for accounts in the derivation path #17

newtonick opened this issue Jun 11, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@newtonick
Copy link
Collaborator

Derivation path in seedsigner currently only supports m/84'/0'/0'/2'. Would be a good advanced feature if the derivation path could be altered specifically to add account support. If the "account number" could be incremented in an advanced settings screen (m/84'/0'/{account}') this would allow for multiple wallets with the same seed phrases.

@newtonick newtonick changed the title Add support for Accounts in the derivation path Add support for accounts in the derivation path Jun 11, 2021
@SeedSigner
Copy link
Owner

Agree that this would be a very cool and useful feature to implement. The trick with the settings in SeedSigner is going to be getting the menu settings so they are not simple. It also calls into question some sort of persistence for settings, as we add more options in settings. But as to this particular account number option, agree that it would be a great advanced feature.

@newtonick newtonick reopened this Aug 6, 2021
@newtonick
Copy link
Collaborator Author

Current plan is to add custom derivation support, not just account number for bip84

@SeedSigner SeedSigner added the enhancement New feature or request label Aug 16, 2021
@TKone7
Copy link

TKone7 commented Aug 23, 2021

I am very new to SeedSigner (actually digged deeper through the settings for the first time yesterday). And this was the first shortcoming I noticed. Wanted to import a (dummy) singlesig wallet into Specter and had to go the detour via Electrum. Maybe there would have been an easier way (please let me know). But I would very much support the option to export a specific account over QR.

Would also be up helping implement / test this.

@newtonick
Copy link
Collaborator Author

Custom derivation path now allows accounts. Closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants