Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: input validation for color converter #59

Closed
Segelzwerg opened this issue Apr 6, 2024 · 3 comments · Fixed by #91
Closed

MINOR: input validation for color converter #59

Segelzwerg opened this issue Apr 6, 2024 · 3 comments · Fixed by #91
Milestone

Comments

@Segelzwerg
Copy link
Owner

After the merge of #41 the color converter requires checks for valid inputs of HEX color strings.

@Segelzwerg Segelzwerg added this to the 1.0.0 milestone Apr 6, 2024
@HealthyDoggo
Copy link
Contributor

How do you want the error to be thrown if an input passed is not a valid HEX color string?

@Segelzwerg
Copy link
Owner Author

How do you want the error to be thrown if an input passed is not a valid HEX color string?

Hi @HealthyDoggo thanks for contributing.

How about we create a custom error that is called something NonHexValueError?

@HealthyDoggo
Copy link
Contributor

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants