Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review content of metadata in detector config files #567

Open
ascillitoe opened this issue Jul 25, 2022 · 1 comment
Open

Review content of metadata in detector config files #567

ascillitoe opened this issue Jul 25, 2022 · 1 comment

Comments

@ascillitoe
Copy link
Contributor

Our detector self.meta attribute currently contains the following information:

DEFAULT_META = {
    "name": None,
    "online": None,  # true or false
    "data_type": None,  # tabular, image or time-series
    "version": None,
    "detector_type": None  # drift, outlier or adversarial
}  # type: Dict

Whereas the metadata in detector config files contains:

[meta]
version = "0.10.0rc1"
config_spec = "0.1"
version_warning = false

We should review what content it makes sense to include in detector config files. Fields such as detector_type and online could be useful to view without instantiating a detector. In #564 it was decided not to include the entirety of self.meta in config files since this leads to excessive duplication (e.g. name, backend and data_type).

@ascillitoe
Copy link
Contributor Author

We should also review the intention behind the data_type kwarg, and whether it is even needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant