-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error checks in deployment for kNN detector #761
Comments
mauicv
changed the title
Just to highlight, the implication of this is presumably that
Error checks in deployment
Mar 17, 2023
NotFitException
's will **not** be raised by detectors that have been torch scripted, i.e. by detectors in deployment? Don't think this is something to worry about too much for now, but wonder if we should do one or both of the following:
mauicv
changed the title
Error checks in deployment
Error checks in deployment for kNN detector
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
torchscript doesn't like control flow so we have to use one of @torch.jit.ignore or @torch.jit.unused in order to script the kNN detector. The implication of this is that
NotFitException
's will not be raised by detectors that have been torch scripted, i.e. by detectors in deployment? Don't think this is something to worry about too much for now, but wonder if we should do one or both of the following:torch
versions to see if they improve this torch script limitation.cc: @mauicv @jklaise
Originally posted by @ascillitoe in #677 (comment)
The text was updated successfully, but these errors were encountered: