Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checks in deployment for kNN detector #761

Open
Tracked by #806
mauicv opened this issue Mar 17, 2023 · 0 comments
Open
Tracked by #806

Error checks in deployment for kNN detector #761

mauicv opened this issue Mar 17, 2023 · 0 comments
Assignees

Comments

@mauicv
Copy link
Collaborator

mauicv commented Mar 17, 2023

torchscript doesn't like control flow so we have to use one of @torch.jit.ignore or @torch.jit.unused in order to script the kNN detector. The implication of this is that NotFitException's will not be raised by detectors that have been torch scripted, i.e. by detectors in deployment? Don't think this is something to worry about too much for now, but wonder if we should do one or both of the following:

  1. Ensure this caveat is highlighted in the documentation somewhere, as I imagine users will at some point deploy unfitted detectors and get unclear error messages.
  2. Open an issue for us to think about possible solutions for this, or at least keep an eye on future torch versions to see if they improve this torch script limitation.

cc: @mauicv @jklaise

Originally posted by @ascillitoe in #677 (comment)

@mauicv mauicv changed the title Just to highlight, the implication of this is presumably that NotFitException's will **not** be raised by detectors that have been torch scripted, i.e. by detectors in deployment? Don't think this is something to worry about too much for now, but wonder if we should do one or both of the following: Error checks in deployment Mar 17, 2023
@mauicv mauicv changed the title Error checks in deployment Error checks in deployment for kNN detector Mar 17, 2023
@mauicv mauicv mentioned this issue Mar 17, 2023
17 tasks
@mauicv mauicv self-assigned this Mar 17, 2023
@mauicv mauicv mentioned this issue Jun 12, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant