check if dependency is dict before checking the key

SeldonIO · Jun 20, 2020 · a737ae5 · a737ae5
1 parent 4c6cbf0
commit a737ae5
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/servers/mlflowserver/mlflowserver/conda_env_create.py b/servers/mlflowserver/mlflowserver/conda_env_create.py
@@ -74,10 +74,13 @@ def inject_base_reqs(env_file_path):
     if "dependencies" not in conda_env:
         conda_env["dependencies"] = []
 
-    dependency = next((dep for dep in conda_env["dependencies"] if "pip" in dep), None)
-    if dependency is not None:
-        dependency["pip"].append(f"-r {BASE_REQS_PATH}")
-    else:
+    pip_exists = False
+    for dep in conda_env["dependencies"]:
+        if isinstance(dep, dict) and "pip" in dep:
+            pip_exists = True
+            dep["pip"].append(f"-r {BASE_REQS_PATH}")
+            break
+    if not pip_exists:
         new_entry = {"pip": [f"-r {BASE_REQS_PATH}"]}
         conda_env["dependencies"].append(new_entry)