Skip to content

Commit

Permalink
Update workflow to work on Istio enabled namespace
Browse files Browse the repository at this point in the history
Update workflow to work on Istio enabled namespaces because workflow-controller created pods should have no sidecar otherwise it waits forever on  first step
  • Loading branch information
omerfsen authored and seldondev committed Nov 17, 2020
1 parent b5e64ad commit dd82519
Showing 1 changed file with 15 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ spec:
template: upload-object-store-template

- name: create-seldon-resource-template
metadata:
annotations:
sidecar.istio.io/inject: "false"
resource:
action: create
manifest: |
Expand Down Expand Up @@ -81,6 +84,9 @@ spec:
replicas: {{ .Values.seldonDeployment.replicas }}
- name: wait-seldon-resource-template
metadata:
annotations:
sidecar.istio.io/inject: "false"
script:
image: bitnami/kubectl:1.17
command: [bash]
Expand All @@ -90,6 +96,9 @@ spec:
deploy/$(kubectl get deploy -l seldon-deployment-id="{{ .Values.seldonDeployment.name }}" -o jsonpath='{.items[0].metadata.name}')
- name: download-object-store-template
metadata:
annotations:
sidecar.istio.io/inject: "false"
script:
image: minio/{{ .Values.minio.minioclient.image }}
env:
Expand All @@ -114,6 +123,9 @@ spec:
mc cp minio-local/{{ .Values.minio.inputDataPath }} /assets/input-data.txt
- name: process-batch-inputs-template
metadata:
annotations:
sidecar.istio.io/inject: "false"
script:
image: {{ .Values.seldonDeployment.image }}
volumeMounts:
Expand All @@ -136,6 +148,9 @@ spec:
--output-data-path "/assets/output-data.txt"
- name: upload-object-store-template
metadata:
annotations:
sidecar.istio.io/inject: "false"
script:
image: minio/{{ .Values.minio.minioclient.image }}
volumeMounts:
Expand Down

0 comments on commit dd82519

Please sign in to comment.