Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not control retry_policy from SeldonDeployment yaml file #1137

Closed
yufengshan opened this issue Nov 25, 2019 · 2 comments
Closed

Can not control retry_policy from SeldonDeployment yaml file #1137

yufengshan opened this issue Nov 25, 2019 · 2 comments
Milestone

Comments

@yufengshan
Copy link

yufengshan commented Nov 25, 2019

I am trying to control the ambassador retry_policy from SeldonDeployment using the seldon.io/ambassador-config: at spec section.

I want to change the num_retries and retry_on for different services and then created customize annotation to test the ambassador config. Seems the operator can not pick up the retry_policy config, I looked into the code, it looks like the operator code only process the top level (retry_policy level) , but can not go inside retry_policy (num_retries and retry_on). Can you please take a look? Either the document I am following is missing something or the code may need more function to process the num_retries. Thanks.

The doc I used : https://docs.seldon.io/projects/seldon-core/en/latest/ingress/ambassador.html#custom-amabassador-configuration

@ukclivecox
Copy link
Contributor

Have you tried https://docs.seldon.io/projects/seldon-core/en/latest/examples/ambassador_custom.html ?
Can you post the deployment yaml you are using?

@ukclivecox ukclivecox added this to the 1.0 milestone Nov 28, 2019
@ukclivecox
Copy link
Contributor

reopen if still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants